Re: [PATCH 06/15] mm/swap: remove buggy cache->nr check in refill_swap_slots_cache

[Andrew Morton]

On Mon, 16 May 2022 10:00:43 +0800 Miaohe Lin <linmiaohe@xxxxxxxxxx> wrote:

> On 2022/5/12 21:37, David Hildenbrand wrote:
> > On 09.05.22 15:14, Miaohe Lin wrote:
> >> refill_swap_slots_cache is always called when cache->nr is 0. And if
> >> cache->nr != 0, we should return cache->nr instead of 0. So remove
> >> such buggy and confusing check.
> > 
> > Not sure about the "cache->nr != 0, we should return cache->nr instead
> > of 0" part, I'd just drop that from the patch description. We'd actually
> > end up overwriting cache->nr after your change, which doesn't sound
> > right and also different to what you describe here.
> 
> Will do.

I've updated the changleog to simply

: refill_swap_slots_cache is always called when cache->nr is 0.  So remove
: such buggy and confusing check.