Re: [RFC net-next] bonding: netlink error message support for options

From: Stephen Hemminger
Date: Tue May 17 2022 - 18:44:28 EST


On Tue, 17 May 2022 16:31:19 -0400
Jonathan Toppins <jtoppins@xxxxxxxxxx> wrote:

> This is an RFC because the current NL_SET_ERR_MSG() macros do not support
> printf like semantics so I rolled my own buffer setting in __bond_opt_set().
> The issue is I could not quite figure out the life-cycle of the buffer, if
> rtnl lock is held until after the text buffer is copied into the packet
> then we are ok, otherwise, some other type of buffer management scheme will
> be needed as this could result in corrupted error messages when modifying
> multiple bonds.

Might be better for others in long term if NL_SET_ERR_MSG() had printf like
semantics. Surely this isn't going to be first or last case.

Then internally, it could print right to the netlink message.