Re: [PATCH] riscv: dts: microchip: fix gpio1 reg property typo

From: Conor.Dooley
Date: Tue May 17 2022 - 11:58:17 EST




On 17/05/2022 16:53, Palmer Dabbelt wrote:
> On Tue, 17 May 2022 07:51:32 PDT (-0700), krzysztof.kozlowski@xxxxxxxxxx wrote:
>> On 17/05/2022 12:40, Conor Paxton wrote:
>>> Fix reg address typo in the gpio1 stanza.
>>>
>>> Signed-off-by: Conor Paxton <conor.paxton@xxxxxxxxxxxxx>
>>> ---
>>>  arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 2 +-
>>
>> Pressed send to fast...
>>
>> Please add Fixes tag, unless fixed commit SHA is not considered stable.
>
> Conor might be asleep, and as it's late in the cycle I figured I'd just chime in directly.  This LGTM, I usually add fixes myself if there aren't any.  Unless there's any objections to

It's not even 1700 yet, neither Conor on the mail is asleep!

>
> Fixes: 528a5b1f2556 ("riscv: dts: microchip: add new peripherals to icicle kit device tree")

Saw Krzysztof's mail as I went out the door, I was gonna add an RB & the fixes tag
once I got home but beaten to the punch.
FWIW at this point:

Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

>
> I'll put this on fixes.
>
> Thanks!
>
>
>>
>>
>> Best regards,
>> Krzysztof