Re: [PATCH 03/12] net: mana: Handle vport sharing between devices

From: Stephen Hemminger
Date: Tue May 17 2022 - 11:19:28 EST


On Tue, 17 May 2022 02:04:27 -0700
longli@xxxxxxxxxxxxxxxxx wrote:

> diff --git a/drivers/net/ethernet/microsoft/mana/mana.h b/drivers/net/ethernet/microsoft/mana/mana.h
> index 51bff91b63ee..26f14fcb6a61 100644
> --- a/drivers/net/ethernet/microsoft/mana/mana.h
> +++ b/drivers/net/ethernet/microsoft/mana/mana.h
> @@ -375,6 +375,7 @@ struct mana_port_context {
> unsigned int num_queues;
>
> mana_handle_t port_handle;
> + atomic_t port_use_count;

Could this be a refcount_t instead?
The refcount_t has protections against under/overflow.