Re: [PATCH v3 0/2] Fix topdown event weak grouping

[Arnaldo Carvalho de Melo]

Em Mon, May 16, 2022 at 10:27:22PM -0700, Ian Rogers escreveu:
> Keep topdown events within a group when a weak group is broken. This
> is a requirement as topdown events must form a group.
> 
> Add perf stat testing including for required topdown event group
> behaviors.
> 
> Note: as with existing topdown evsel/evlist code topdown events are
> assumed to be on the PMU "cpu". On Alderlake the PMU "cpu_core" should
> also be tested. Future changes can fix Alderlake.

Thanks, applied.

- Arnaldo

 
> v3. Fix computation of number of events in leader's group.
>     Adds reviewed-by: Liang, Kan <kan.liang@xxxxxxxxxxxxxxx
> v2. Correct behavior wrt pmu prefixed events and avoid the test using
>     deprecated events: Suggested-by: Liang, Kan <kan.liang@xxxxxxxxxxxxxxx>
> 
> Ian Rogers (2):
>   perf evlist: Keep topdown counters in weak group
>   perf test: Add basic stat and topdown group test
> 
>  tools/perf/arch/x86/util/evsel.c | 12 ++++++
>  tools/perf/tests/shell/stat.sh   | 67 ++++++++++++++++++++++++++++++++
>  tools/perf/util/evlist.c         | 16 +++++++-
>  tools/perf/util/evsel.c          | 10 +++++
>  tools/perf/util/evsel.h          |  3 ++
>  5 files changed, 106 insertions(+), 2 deletions(-)
>  create mode 100755 tools/perf/tests/shell/stat.sh
> 
> -- 
> 2.36.0.550.gb090851708-goog

-- 

- Arnaldo