Re: [PATCH v2 2/2] ceph: wait the first reply of inflight unlink/rmdir

From: Xiubo Li
Date: Tue May 17 2022 - 08:00:34 EST



On 5/17/22 7:54 PM, Jeff Layton wrote:
On Tue, 2022-05-17 at 19:49 +0800, Xiubo Li wrote:
On 5/17/22 7:35 PM, Jeff Layton wrote:
On Tue, 2022-05-17 at 09:03 +0800, Xiubo Li wrote:
In async unlink case the kclient won't wait for the first reply
from MDS and just drop all the links and unhash the dentry and then
succeeds immediately.

For any new create/link/rename,etc requests followed by using the
same file names we must wait for the first reply of the inflight
...
I doubt you need this large a hashtable, particularly given that this is
per-superblock. In most cases, we'll just have a few of these in flight
at a time.
A global hashtable ? And set the order to 8 ?
Per-sb is fine, IMO. 6-8 bits sounds reasonable.

Sure, let's use 8. From my snaptest I can see there had a lot of dentries in the hashtable at the same time some times.

-- Xiubo