Re: [PATCH] qedr: Remove unnecessary synchronize_irq() before free_irq()

From: Jason Gunthorpe
Date: Tue May 17 2022 - 07:54:41 EST


On Fri, May 13, 2022 at 08:16:47AM +0000, cgel.zte@xxxxxxxxx wrote:
> From: Minghao Chi <chi.minghao@xxxxxxxxxx>
>
> Calling synchronize_irq() right before free_irq() is quite useless. On one
> hand the IRQ can easily fire again before free_irq() is entered, on the
> other hand free_irq() itself calls synchronize_irq() internally (in a race
> condition free way), before any state associated with the IRQ is freed.
>
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: Minghao Chi <chi.minghao@xxxxxxxxxx>
> Acked-by: Michal Kalderon <michal.kalderon@xxxxxxxxxxx>
> ---
> drivers/infiniband/hw/qedr/main.c | 1 -
> 1 file changed, 1 deletion(-)

Applied to for-next, thanks

Jason