Re: [PATCH] dma-buf: fix use of DMA_BUF_SET_NAME_{A,B} in userspace
From: Jérôme Pouiller
Date: Tue May 17 2022 - 07:00:40 EST
On Tuesday 17 May 2022 11:37:27 CEST Christian König wrote:
> Am 17.05.22 um 10:32 schrieb Jérôme Pouiller:
> > [add stable@xxxxxxxxxxxxxxx to the recipients]
>
> Well, that's not what I suggested :)
>
> The question was if we should add a CC stable tag while pushing this.
>
> Greg might be complaining that you shouldn't CC the stable list manually.
He did :). I was indeed unaware of this process.
> > On Tuesday 17 May 2022 09:30:24 CEST Christian König wrote:
> >> Am 17.05.22 um 09:27 schrieb Jerome Pouiller:
> >>> From: Jérôme Pouiller <jerome.pouiller@xxxxxxxxxx>
> >>>
> >>> The typedefs u32 and u64 are not available in userspace. Thus user get
> >>> an error he try to use DMA_BUF_SET_NAME_A or DMA_BUF_SET_NAME_B:
> >>>
> >>> $ gcc -Wall -c -MMD -c -o ioctls_list.o ioctls_list.c
> >>> In file included from /usr/include/x86_64-linux-gnu/asm/ioctl.h:1,
> >>> from /usr/include/linux/ioctl.h:5,
> >>> from /usr/include/asm-generic/ioctls.h:5,
> >>> from ioctls_list.c:11:
> >>> ioctls_list.c:463:29: error: ‘u32’ undeclared here (not in a function)
> >>> 463 | { "DMA_BUF_SET_NAME_A", DMA_BUF_SET_NAME_A, -1, -1 }, // linux/dma-buf.h
> >>> | ^~~~~~~~~~~~~~~~~~
> >>> ioctls_list.c:464:29: error: ‘u64’ undeclared here (not in a function)
> >>> 464 | { "DMA_BUF_SET_NAME_B", DMA_BUF_SET_NAME_B, -1, -1 }, // linux/dma-buf.h
> >>> | ^~~~~~~~~~~~~~~~~~
> >>>
> >>> The issue was initially reported here[1].
> >>>
> >>>
> >>> Signed-off-by: Jérôme Pouiller <jerome.pouiller@xxxxxxxxxx>
> >> Good catch, Reviewed-by: Christian König <christian.koenig@xxxxxxx>
> >>
> >> CC: stable?
> > Done
> >
> >> Fixes: ?
> > Fixes: a5bff92eaac4 ("dma-buf: Fix SET_NAME ioctl uapi")
>
> Going to push that to drm-misc-fixes with the Fixes: and CC: stable tag
> added.
--
Jérôme Pouiller