Re: [PATCH v8 2/8] hwtracing: hisi_ptt: Add trace function support for HiSilicon PCIe Tune and Trace device

From: John Garry
Date: Tue May 17 2022 - 04:21:57 EST


On 17/05/2022 09:09, Yicong Yang wrote:
+    target = cpumask_any(cpumask_of_node(dev_to_node(&hisi_ptt->pdev->dev)));
+    if (target < nr_cpumask_bits) {
the comment for cpumask_any() hints to check against nr_cpu_ids - any specific reason to check against nr_cpumask_bits?

here should be:
if (target >= nr_cpumask_bits) {

will fix this up.


I am still not sure that using nr_cpumask_bits is correct.