Re: [PATCH v3 1/3] fanotify: Ensure consistent variable type for response

[Paul Moore]

On Mon, May 16, 2022 at 4:22 PM Richard Guy Briggs <rgb@xxxxxxxxxx> wrote:
>
> The user space API for the response variable is __u32. This patch makes
> sure that the whole path through the kernel uses u32 so that there is
> no sign extension or truncation of the user space response.
>
> Suggested-by: Steve Grubb <sgrubb@xxxxxxxxxx>
> Link: https://lore.kernel.org/r/12617626.uLZWGnKmhe@x2
> Signed-off-by: Richard Guy Briggs <rgb@xxxxxxxxxx>
> ---
>  fs/notify/fanotify/fanotify.h      | 2 +-
>  fs/notify/fanotify/fanotify_user.c | 6 +++---
>  include/linux/audit.h              | 6 +++---
>  kernel/auditsc.c                   | 2 +-
>  4 files changed, 8 insertions(+), 8 deletions(-)

We're at -rc7, so this should wait until after the upcoming merge
window, but it looks okay to me.

Acked-by: Paul Moore <paul@xxxxxxxxxxxxxx>

-- 
paul-moore.com