Re: [PATCH -next v2] mtd: st_spi_fsm: add missing clk_disable_unprepare() in stfsm_remove()

[Miquel Raynal]

Hi Yang,

yangyingliang@xxxxxxxxxx wrote on Mon, 16 May 2022 17:29:11 +0800:

> Clock source is prepared and enabled by clk_prepare_enable()
> in probe function, but not disabled or unprepared in remove
> function.
> 

Applied to mtd/next, thanks!

> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> ---
> v2:
>   make the commit message and title more proper.
> ---
>  drivers/mtd/devices/st_spi_fsm.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mtd/devices/st_spi_fsm.c b/drivers/mtd/devices/st_spi_fsm.c
> index 983999c020d6..d3377b10fc0f 100644
> --- a/drivers/mtd/devices/st_spi_fsm.c
> +++ b/drivers/mtd/devices/st_spi_fsm.c
> @@ -2126,6 +2126,8 @@ static int stfsm_remove(struct platform_device *pdev)
>  {
>  	struct stfsm *fsm = platform_get_drvdata(pdev);
>  
> +	clk_disable_unprepare(fsm->clk);
> +
>  	return mtd_device_unregister(&fsm->mtd);
>  }
>  


Thanks,
Miquèl