Re: [PATCH 4/8] s390/entry: workaround llvm's IAS limitations

From: Heiko Carstens
Date: Mon May 16 2022 - 10:06:53 EST


On Mon, May 16, 2022 at 01:11:48PM +0200, Alexander Gordeev wrote:
> > So I'd suggest: leave this code as is, and at some later point move
> > "rework" the early machine check handler code.
> >
> > What do you think?
>
> Sounds very reasonable. Please, find my:
>
> Acked-by: Alexander Gordeev <agordeev@xxxxxxxxxxxxx>

Thanks!

> Also, how such a follow-up looks to you?
...
> slgfi %r14,\start
> clgfi %r14,\end - \start

I think using an address as an immediate value is a step in the wrong
direction, since I'd like to have all code pc-relative. And as far as
I can tell this new construct would only work as long as \start has an
absolute address that is low enough so that it would work / fit with
slgfi.
Of course this will likely always be the case, but I still think this
is not the way we should go.