Re: [PATCH 2/3] media: st-mipid02: add support for YVYU and VYUY formats

From: Benjamin Mugnier
Date: Mon May 16 2022 - 06:12:49 EST




On 16/05/2022 11:19, Hugues Fruchet wrote:
> From: Alain Volmat <alain.volmat@xxxxxxxxxxx>
>
> Those two formats were missing in the list of supported MBUS
> formats.
>
> Signed-off-by: Alain Volmat <alain.volmat@xxxxxxxxxxx>

Reviewed-by: Benjamin Mugnier <benjamin.mugnier@xxxxxxxxxxx>

> ---
> drivers/media/i2c/st-mipid02.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/st-mipid02.c b/drivers/media/i2c/st-mipid02.c
> index 59b48026c752..fe884d81b08b 100644
> --- a/drivers/media/i2c/st-mipid02.c
> +++ b/drivers/media/i2c/st-mipid02.c
> @@ -64,7 +64,8 @@ static const u32 mipid02_supported_fmt_codes[] = {
> MEDIA_BUS_FMT_SGRBG12_1X12, MEDIA_BUS_FMT_SRGGB12_1X12,
> MEDIA_BUS_FMT_UYVY8_1X16, MEDIA_BUS_FMT_BGR888_1X24,
> MEDIA_BUS_FMT_RGB565_2X8_LE, MEDIA_BUS_FMT_RGB565_2X8_BE,
> - MEDIA_BUS_FMT_YUYV8_2X8, MEDIA_BUS_FMT_UYVY8_2X8,
> + MEDIA_BUS_FMT_YUYV8_2X8, MEDIA_BUS_FMT_YVYU8_2X8,
> + MEDIA_BUS_FMT_UYVY8_2X8, MEDIA_BUS_FMT_VYUY8_2X8,
> MEDIA_BUS_FMT_JPEG_1X8
> };
>
> @@ -133,7 +134,9 @@ static int bpp_from_code(__u32 code)
> return 12;
> case MEDIA_BUS_FMT_UYVY8_1X16:
> case MEDIA_BUS_FMT_YUYV8_2X8:
> + case MEDIA_BUS_FMT_YVYU8_2X8:
> case MEDIA_BUS_FMT_UYVY8_2X8:
> + case MEDIA_BUS_FMT_VYUY8_2X8:
> case MEDIA_BUS_FMT_RGB565_2X8_LE:
> case MEDIA_BUS_FMT_RGB565_2X8_BE:
> return 16;
> @@ -164,7 +167,9 @@ static u8 data_type_from_code(__u32 code)
> return 0x2c;
> case MEDIA_BUS_FMT_UYVY8_1X16:
> case MEDIA_BUS_FMT_YUYV8_2X8:
> + case MEDIA_BUS_FMT_YVYU8_2X8:
> case MEDIA_BUS_FMT_UYVY8_2X8:
> + case MEDIA_BUS_FMT_VYUY8_2X8:
> return 0x1e;
> case MEDIA_BUS_FMT_BGR888_1X24:
> return 0x24;
>