RE: [PATCH 3/3] dt-bindings: usb: add documentation for aspeed udc

From: Neal Liu
Date: Mon May 16 2022 - 02:00:47 EST


> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Monday, May 16, 2022 1:54 PM
> To: Neal Liu <neal_liu@xxxxxxxxxxxxxx>; Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof
> Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>; Joel Stanley <joel@xxxxxxxxx>;
> Andrew Jeffery <andrew@xxxxxxxx>; Felipe Balbi <balbi@xxxxxxxxxx>; Sumit
> Semwal <sumit.semwal@xxxxxxxxxx>; Christian König
> <christian.koenig@xxxxxxx>; Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>;
> Li Yang <leoyang.li@xxxxxxx>
> Cc: linux-aspeed@xxxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; linux-media@xxxxxxxxxxxxxxx;
> dri-devel@xxxxxxxxxxxxxxxxxxxxx; linaro-mm-sig@xxxxxxxxxxxxxxxx
> Subject: Re: [PATCH 3/3] dt-bindings: usb: add documentation for aspeed udc
>
> On 16/05/2022 03:59, Neal Liu wrote:
> >>> Okay, I could rename it for next patch if you preferred.
> >>> But there are lots of yaml files which are not named as first compatible.
> >>
> >> Yes, I know, I quite likely I also produced such bindings, but a
> >> specific name is rather preferred. Otherwise you will have a
> >> difficult naming choice when your next Aspeed UDC requires new
> >> bindings file because of some differences (not yet known now).
> >>
> > We can rename the bindings if next Aspeed UDC needs, don't you think?
> > Currently, Aspeed has no requirement.
>
> So just use proper name from the beginning....
>
Okay, I'll rename it for next patch.
Thanks for the review.

>
> Best regards,
> Krzysztof