Re: [PATCH 1/2] tpm: Fix buffer access in tpm2_get_tpm_pt()

[Jarkko Sakkinen]

On Fri, May 06, 2022 at 02:31:46PM +0200, Stefan Mahnke-Hartmann wrote:
> Under certain conditions uninitialized memory will be accessed.
> As described by TCG Trusted Platform Module Library Specification,
> rev. 1.59 (Part 3: Commands), if a TPM2_GetCapability is received,
> requesting a capability, the TPM in Field Upgrade mode may return a
                                      ~~~~~~~~~~~~~~~~~~

Looks like random picks for casing: two words with upper case letter and
one with lowe case.

> zero length list.
> Check the property count in tpm2_get_tpm_pt().
> 
> Fixes: 2ab3241161b3 ("tpm: migrate tpm2_get_tpm_pt() to use struct tpm_buf")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Stefan Mahnke-Hartmann <stefan.mahnke-hartmann@xxxxxxxxxxxx>

Which section is this in that specification documented?

I looked into section 30.2 but could not find the part that documents this
behaviour, i.e. returning success in FW upgrade mode. Why it wouldn't just
return TPM_RC_UPGRADE?

BR, Jarkko