Re: [PATCH v2] lib/string_helpers: fix not adding strarray to device's resource list.

[Andrew Morton]

On Fri,  6 May 2022 15:36:22 +0800 Puyou Lu <puyou.lu@xxxxxxxxx> wrote:

> Add allocated strarray to device's resource list. This is a must to
> automatically release strarray when the device disappears.

So at present we have a memory leak?

Is this likely to be serious enough to justify backporting the fix into
-stable kernels?

> --- a/lib/string_helpers.c
> +++ b/lib/string_helpers.c
> @@ -757,6 +757,9 @@ char **devm_kasprintf_strarray(struct device *dev, const char *prefix, size_t n)
>  		return ERR_PTR(-ENOMEM);
>  	}
>  
> +	ptr->n = n;
> +	devres_add(dev, ptr);
> +
>  	return ptr->array;
>  }
>  EXPORT_SYMBOL_GPL(devm_kasprintf_strarray);