Re: [PATCH v2] mm/ksm: introduce ksm_force for each process

From: kernel test robot
Date: Sat May 07 2022 - 00:47:22 EST


Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on akpm-mm/mm-everything]
[also build test ERROR on next-20220506]
[cannot apply to hnaz-mm/master kees/for-next/pstore linus/master v5.18-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/intel-lab-lkp/linux/commits/cgel-zte-gmail-com/mm-ksm-introduce-ksm_force-for-each-process/20220507-094557
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20220507/202205071213.kLZzW7OV-lkp@xxxxxxxxx/config)
compiler: arceb-elf-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/bc6a122b9e10290755c811e7fa23dd60d39303e2
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review cgel-zte-gmail-com/mm-ksm-introduce-ksm_force-for-each-process/20220507-094557
git checkout bc6a122b9e10290755c811e7fa23dd60d39303e2
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

mm/ksm.c: In function 'ksm_vma_check':
>> mm/ksm.c:343:17: error: 'turn' undeclared (first use in this function)
343 | turn false;
| ^~~~
mm/ksm.c:343:17: note: each undeclared identifier is reported only once for each function it appears in
>> mm/ksm.c:343:21: error: expected ';' before 'false'
343 | turn false;
| ^~~~~~
| ;


vim +/turn +343 mm/ksm.c

336
337 /* Check if vma is qualified for ksmd scanning */
338 static bool ksm_vma_check(struct vm_area_struct *vma)
339 {
340 unsigned long vm_flags = vma->vm_flags;
341
342 if (!(vma->vm_flags & VM_MERGEABLE) && !(vma->vm_mm->ksm_force))
> 343 turn false;
344
345 if (vm_flags & (VM_SHARED | VM_MAYSHARE |
346 VM_PFNMAP | VM_IO | VM_DONTEXPAND |
347 VM_HUGETLB | VM_MIXEDMAP))
348 return false; /* just ignore this vma*/
349
350 if (vma_is_dax(vma))
351 return false;
352

--
0-DAY CI Kernel Test Service
https://01.org/lkp