Re: [PATCH] x86/sgx: simplify the return expression of sgx_drv_init()

[Jarkko Sakkinen]

On Thu, May 05, 2022 at 10:31:41AM -0700, Dave Hansen wrote:
> On 5/4/22 19:16, cgel.zte@xxxxxxxxx wrote:
> > From: Minghao Chi <chi.minghao@xxxxxxxxxx>
> > 
> > Simplify the return expression.
> > 
> > Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> > Signed-off-by: Minghao Chi <chi.minghao@xxxxxxxxxx>
> 
> Folks, I'd really encourage you to spend your time elsewhere.  These
> "cleanup" or "simplify" patches as a whole have high rates of bugs.  I
> don't trust them.  Plus, they don't really make the code easier to
> understand.

I agree. I get this kind of clean up in the context of doing something
to the functionality (in the same path) but it does not live by its own.

Plus, these type of patches add to the effort backporting fixes.

BR, Jarkko