Re: (subset) [PATCH] soc: qcom: pdr: use static for servreg_* variables

[Bjorn Andersson]

On Fri, 22 Apr 2022 13:38:06 -0400, Tom Rix wrote:
> Sparse reports this repesentative issue
> pdr_internal.h:31:22: warning: symbol 'servreg_location_entry_ei' was not declared. Should it be static?
> Similar for other servreg_*
> 
> Global variables should not be defined in header files.
> This only works because pdr_internal.h is only included
> by pdr_interface.c.  Single file use variables should be
> static so add static to their storage-class specifiers.
> 
> [...]

Applied, thanks!

[1/1] soc: qcom: pdr: use static for servreg_* variables
      commit: 28e3dc8f8cd37eedc14e97e80a7a2e33359491df

Best regards,
-- 
Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>