Re: [PATCH v1 1/3] kallsyms: avoid hardcoding the buffer size

From: James Bottomley
Date: Fri May 06 2022 - 10:48:11 EST


On Fri, 2022-05-06 at 14:58 +0200, Miguel Ojeda wrote:
> Hi James,
>
> On Fri, May 6, 2022 at 1:19 PM James Bottomley
> <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote:
> > When you raise KSYM_NAME_LEN to 512, this on stack allocation
> > becomes 2049 bytes. How did you manage not to trigger the frame
> > size warning, which is 1024 on 32 bit and 2048 on 64 bit by
> > default?
>
> Thanks for taking a look!
>
> If you mean `CONFIG_FRAME_WARN`, that applies to kernel objects, not
> scripts.

Oh, right, I missed that it was a script. Forget the comment then; we
only have a restricted stack inside the kernel not in userspace.

James