Re: [PATCH net-next 3/5] net: hns3: add byte order conversion for PF to VF mailbox message

[huangguangbin (A)]

On 2022/5/6 9:47, Jakub Kicinski wrote:
> On Thu, 5 May 2022 20:44:42 +0800 Guangbin Huang wrote:
> > From: Jie Wang <wangjie125@xxxxxxxxxx>
> >
> > Currently, hns3 mailbox processing between PF and VF missed to convert
> > message byte order and use data type u16 instead of __le16 for mailbox
> > data process. These processes may cause problems between different
> > architectures.
> >
> > So this patch uses __le16/__le32 data type to define mailbox data
> > structures. To be compatible with old hns3 driver, these structures use
> > one-byte alignment. Then byte order conversions are added to mailbox
> > messages from PF to VF.
>
> This adds a few sparse [1] warnings, you must have missed a few
> conversions.
>
> Please wait at least 24h for additional feedback before reposting.
>
> [1] https://www.kernel.org/doc/html/latest/dev-tools/sparse.html
>
> .
Ok, thanks