Re: [RESEND PATCH v3] scsi: ufs: exclude UECxx from SFR dump list
From: Martin K. Petersen
Date: Fri May 06 2022 - 06:03:48 EST
On Thu, 31 Mar 2022 10:24:05 +0900, Kiwoong Kim wrote:
> v2 -> v3: add fixes
> v1 -> v2: does skipping only for zero offset
>
> These are ROC type things that means their values
> are cleared when the SFRs are read.
> They are usually read in ISR when an UIC error occur.
> Thus, their values would be zero at many cases. And
> there might be a little bit risky when they are read to
> be cleared before the ISR reads them, e.g. the case that
> a command is timed-out, ufshcd_dump_regs is called in
> ufshcd_abort and an UIC error occurs at the nearly
> same time. In this case, ISR will be called but UFS error handler
> will not be scheduled.
> This patch is to make UFS driver not read those SFRs in the
> dump function, i.e. ufshcd_dump_regs.
>
> [...]
Applied to 5.19/scsi-queue, thanks!
[1/1] scsi: ufs: exclude UECxx from SFR dump list
https://git.kernel.org/mkp/scsi/c/ef60031022eb
--
Martin K. Petersen Oracle Linux Engineering