Re: [PATCH v10, 16/17] media: mediatek: vcodec: support stateless VP9 decoding

[yunfei.dong@xxxxxxxxxxxx]

Hi Nicolas,

Thanks for your suggestion.

On Thu, 2022-05-05 at 18:20 -0400, Nícolas F. R. A. Prado wrote:
> On Tue, Apr 26, 2022 at 06:08:27PM +0800, Yunfei Dong wrote:
> > Add support for VP9 decoding using the stateless API,
> > as supported by MT8192. And the drivers is lat and core
> > architecture.
> > 
> > Signed-off-by: Yunfei Dong <yunfei.dong@xxxxxxxxxxxx>
> > Signed-off-by: George Sun <george.sun@xxxxxxxxxxxx>
> > Reviewed-by: AngeloGioacchino Del Regno <
> > angelogioacchino.delregno@xxxxxxxxxxxxx>
> > ---
> >  .../media/platform/mediatek/vcodec/Makefile   |    1 +
> >  .../vcodec/mtk_vcodec_dec_stateless.c         |   26 +-
> >  .../platform/mediatek/vcodec/mtk_vcodec_drv.h |    1 +
> >  .../vcodec/vdec/vdec_vp9_req_lat_if.c         | 2031
> > +++++++++++++++++
> >  .../platform/mediatek/vcodec/vdec_drv_if.c    |    4 +
> >  .../platform/mediatek/vcodec/vdec_drv_if.h    |    1 +
> >  6 files changed, 2061 insertions(+), 3 deletions(-)
> >  create mode 100644
> > drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c
> > 
> 
> ...
> 
> > +		use_128 = !frame_is_intra && !vsi-
> > >frame.uh.last_frame_type;
> > +		v4l2_vp9_adapt_coef_probs(pre_frame_ctx_helper,
> > +					  counts_helper,
> > +					  use_128,
> > +					  frame_is_intra);
> 
> Hi Yunfei,
> 
> I'm getting
> 
> ERROR: modpost: "v4l2_vp9_adapt_noncoef_probs"
> [drivers/media/platform/mediatek/vcodec/mtk-vcodec-dec.ko] undefined!
> ERROR: modpost: "v4l2_vp9_adapt_coef_probs"
> [drivers/media/platform/mediatek/vcodec/mtk-vcodec-dec.ko] undefined!
> 
> when building this series.
> 
> Adding
> 	select V4L2_VP9
> to
> 	config VIDEO_MEDIATEK_VCODEC
> solved the issue.
> 
> Thanks,
> Nícolas
I will fix it in next patch

Best Regards,
Yunfei Dong