Re: [PATCH v4] kernel/crash_core.c : remove redundant check of ck_cmdline

[Baoquan He]

Add Andrew to CC list

On 05/05/22 at 09:32pm, lizhe wrote:
> At the end of get_last_crashkernel(), the judgement of ck_cmdline is
> obviously unnecessary and causes redundance, let's clean it up.
> 
> Signed-off-by: lizhe <sensor1010@xxxxxxx>
> Acked-by: Baoquan He <bhe@xxxxxxxxxx>
> Acked-by: Philipp Rudo <prudo@xxxxxxxxxx>
> ---
>  kernel/crash_core.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> index 256cf6db573c..c232f01a2c54 100644
> --- a/kernel/crash_core.c
> +++ b/kernel/crash_core.c
> @@ -222,9 +222,6 @@ static __init char *get_last_crashkernel(char *cmdline,
>  		p = strstr(p+1, name);
>  	}
>  
> -	if (!ck_cmdline)
> -		return NULL;
> -
>  	return ck_cmdline;
>  }
>  
> -- 
> 2.25.1
>