Re: [PATCH 1/2] ARM: dts: qcom: Add LPG node to pm8941

[Bjorn Andersson]

On Thu 05 May 03:01 CDT 2022, Luca Weiss wrote:

> Hi Bjorn,
> 
> On Mittwoch, 4. Mai 2022 22:54:10 CEST Bjorn Andersson wrote:
> > The PM8941 contains 8 LPG channels, as well as TRILED and LUT blocks.
> > Add a node for these.
> > 
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> > ---
> >  arch/arm/boot/dts/qcom-pm8941.dtsi | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi
> > b/arch/arm/boot/dts/qcom-pm8941.dtsi index cdd2bdb77b32..7881a071b372
> > 100644
> > --- a/arch/arm/boot/dts/qcom-pm8941.dtsi
> > +++ b/arch/arm/boot/dts/qcom-pm8941.dtsi
> > @@ -144,6 +144,15 @@ pm8941_1: pm8941@1 {
> >  		#address-cells = <1>;
> >  		#size-cells = <0>;
> > 
> > +		pm8941_lpg: lpg {
> > +			compatible = "qcom,pm8941-lpg";
> > +
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> 
> Just curious, why doesn't pm8941 have #pwm-cells = <2>; like the other lpg 
> nodes in [0]?

I guess I didn't have a need for the lpg to be a pwm-chip on this pmic,
yet. This could be added now, or at a later point when someone has a
usecase for the pwm-chip.

> Other than that, the node works fine on pm8941. Will send a patch for enabling 
> notification LED on msm8974-FP2 soon.
> 

If you turn that into a Tested-by, and preferably a Reviewed-by, I would
have what I need to merge the two changes.

Looking forward to the FP2 patch.

Thanks,
Bjorn

> Regards
> Luca
> 
> [0] https://lore.kernel.org/linux-arm-msm/20220505022706.1692554-2-bjorn.andersson@xxxxxxxxxx/
> 
> 
> > +
> > +			status = "disabled";
> > +		};
> > +
> >  		pm8941_wled: wled@d800 {
> >  			compatible = "qcom,pm8941-wled";
> >  			reg = <0xd800>;
> 
> 
> 
>