Re: [PATCH V1 12/23] perf evlist: Factor out evlist__dummy_event()

[Ian Rogers]

On Thu, May 5, 2022 at 9:57 AM Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote:
>
> Factor out evlist__dummy_event() so it can be reused.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>

Acked-by: Ian Rogers <irogers@xxxxxxxxxx>

Thanks,
Ian

> ---
>  tools/perf/util/evlist.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
> index 25eae096bdac..78c47cbafbc2 100644
> --- a/tools/perf/util/evlist.c
> +++ b/tools/perf/util/evlist.c
> @@ -242,14 +242,20 @@ int __evlist__add_default(struct evlist *evlist, bool precise)
>         return 0;
>  }
>
> -int evlist__add_dummy(struct evlist *evlist)
> +static struct evsel *evlist__dummy_event(struct evlist *evlist)
>  {
>         struct perf_event_attr attr = {
>                 .type   = PERF_TYPE_SOFTWARE,
>                 .config = PERF_COUNT_SW_DUMMY,
>                 .size   = sizeof(attr), /* to capture ABI version */
>         };
> -       struct evsel *evsel = evsel__new_idx(&attr, evlist->core.nr_entries);
> +
> +       return evsel__new_idx(&attr, evlist->core.nr_entries);
> +}
> +
> +int evlist__add_dummy(struct evlist *evlist)
> +{
> +       struct evsel *evsel = evlist__dummy_event(evlist);
>
>         if (evsel == NULL)
>                 return -ENOMEM;
> --
> 2.25.1
>