Re: [PATCH v2 1/3] x86: Use HALT in default_idle when idle=nomwait cmdline arg is passed

From: Dave Hansen
Date: Thu May 05 2022 - 13:12:51 EST


On 5/5/22 03:48, Wyes Karny wrote:
> When kernel is booted with idle=nomwait avoid selecting MWAIT
> as the default idle state.
>
> If the user boots the kernel with idle=nomwait, it is a clear
> indication that they do not prefer the use of mwait as the default
> idle state. However, the current code does not take this into
> consideration while selecting the default idle state on x86.
>
> This patch fixes it by checking for the idle=nomwait boot option in
> prefer_mwait_c1_over_halt().

There are a couple of places in the existing documentation that talk
about idle=nomwait. Could you please fix those up to make it clear that
the option is no longer specific to intel_idle? We don't need a rewrite
or anything, just some small tweaks in the language.