Re: [PATCH v2 3/3] x86: Fix comment for X86_FEATURE_ZEN

From: Dave Hansen
Date: Thu May 05 2022 - 13:10:44 EST


On 5/5/22 04:04, Wyes Karny wrote:
> The feature X86_FEATURE_ZEN implies that the CPU supports Zen
> microarchitecture. Call this out explicitly in the comment.

Is "supports" the best word here?

A CPU is based on a microarchitecture, it doesn't really support it. I
guess we could say the CPU supports a microarchitecture's *features*,
but that's a bit wordy for a tiny comment.

Maybe:

#define X86_FEATURE_ZEN (7*32+28) /* "" CPU based on Zen uarch */

or spell out "microarchitecture" if there's room.