Re: [PATCH v5] zram: remove double compression logic

From: Minchan Kim
Date: Thu May 05 2022 - 12:57:34 EST


On Thu, May 05, 2022 at 12:44:43PM +0300, Alexey Romanov wrote:
> The 2nd trial allocation under per-cpu presumption has been used to
> prevent regression of allocation failure. However, it makes trouble
> for maintenance without significant benefit. The slowpath branch is
> executed extremely rarely: getting there is problematic. Therefore,
> we delete this branch.
>
> Since b09ab054b69b, zram has used QUEUE_FLAG_STABLE_WRITES to prevent
> buffer change between 1st and 2nd memory allocations. Since we remove
> second trial memory allocation logic, we could remove the STABLE_WRITES
> flag because there is no change buffer to be modified under us.
>
> Signed-off-by: Alexey Romanov <avromanov@xxxxxxxxxxxxxx>
> Signed-off-by: Dmitry Rokosov <ddrokosov@xxxxxxxxxxxxxx>

Acked-by: Minchan Kim <minchan@xxxxxxxxxx>