Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock

[Matthias Brugger]

On 03/05/2022 23:48, Rob Herring wrote:
> On Fri, Apr 29, 2022 at 02:31:31PM +0200, matthias.bgg@xxxxxxxxxx wrote:
> > From: Matthias Brugger <matthias.bgg@xxxxxxxxx>
> >
> > The msdc gate is part of the MMC driver. Delete the binding description
> > of this node.
>
> An ABI break is okay because ...?

Because the code controlling the clock gate was moved to the consumer. This node 
did never ever represent any working implementation of a peripheral. Just a 
lonely clock gate that wasn't used.

Regards,
Matthias

> > Signed-off-by: Matthias Brugger <matthias.bgg@xxxxxxxxx>
> >
> > ---
> >
> > Changes in v2:
> > - Delete compatible in binding descprition as well
> >
> >   .../bindings/arm/mediatek/mediatek,mt8192-clock.yaml      | 8 --------
> >   1 file changed, 8 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> > index c8c67c033f8c..b57cc2e69efb 100644
> > --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> > +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> > @@ -24,7 +24,6 @@ properties:
> >             - mediatek,mt8192-imp_iic_wrap_w
> >             - mediatek,mt8192-imp_iic_wrap_n
> >             - mediatek,mt8192-msdc_top
> > -          - mediatek,mt8192-msdc
> >             - mediatek,mt8192-mfgcfg
> >             - mediatek,mt8192-imgsys
> >             - mediatek,mt8192-imgsys2
> > @@ -107,13 +106,6 @@ examples:
> >           #clock-cells = <1>;
> >       };
> >   
> > -  - |
> > -    msdc: clock-controller@11f60000 {
> > -        compatible = "mediatek,mt8192-msdc";
> > -        reg = <0x11f60000 0x1000>;
> > -        #clock-cells = <1>;
> > -    };
> > -
> >     - |
> >       mfgcfg: clock-controller@13fbf000 {
> >           compatible = "mediatek,mt8192-mfgcfg";
> > --
> > 2.34.1