Re: [PATCH] ARM: dove: fix returnvar.cocci warnings

From: Dave Hansen
Date: Thu May 05 2022 - 12:31:37 EST


On 5/3/22 00:21, Arnd Bergmann wrote:
> On Tue, May 3, 2022 at 4:45 AM kernel test robot <lkp@xxxxxxxxx> wrote:
>> From: kernel test robot <lkp@xxxxxxxxx>
>>
>> arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161
>>
>> Remove unneeded variable used to store return value.
>>
>> Generated by: scripts/coccinelle/misc/returnvar.cocci
>>
>> Reported-by: kernel test robot <lkp@xxxxxxxxx>
>> Signed-off-by: kernel test robot <lkp@xxxxxxxxx>
> I checked the patch, and unfortunately it is wrong, the current code
> needs to stay.
> The problem is the SET_DMA_ERRATA() macro that accesses the
> local 'errata' variable.

0day folks, do we have humans looking over these before they're going
out to the list? If not, can we add some? If so, can the humans get a
little more discerning? ;)