Re: [PATCH] pinctrl: microchip-sgpio: make irq_chip immutable

From: Marc Zyngier
Date: Thu May 05 2022 - 11:06:15 EST


On Thu, 05 May 2022 15:55:01 +0100,
Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> On Thu, Apr 28, 2022 at 1:16 PM Michael Walle <michael@xxxxxxxx> wrote:
>
> > Since recently, the kernel is nagging about mutable irq_chips:
> >
> > [ 4.967050] gpio gpiochip1: (e2004190.gpio-input): not an immutable chip, please consider fixing it!
> >
> > Drop the unneeded copy, flag it as IRQCHIP_IMMUTABLE, add the new
> > helper functions and call the appropriate gpiolib functions.
> >
> > Signed-off-by: Michael Walle <michael@xxxxxxxx>
>
> Patch applied after pulling in Marc's immutable branch.
>
> (Hm a bit confusing since it is a immutable branch with code
> for immutable GPIO chips ... I assume it is both.)

Both indeed. Immutable^2, or something like that.

M.

--
Without deviation from the norm, progress is not possible.