Re: [PATCH v1 1/3] ASoC: cs42l42: Move CS42L42 register descriptions to general include

From: Mark Brown
Date: Thu May 05 2022 - 08:19:27 EST


On Wed, May 04, 2022 at 05:12:34PM +0100, Stefan Binding wrote:
> This is to allow the hda driver to have access to the register names,
> for improved maintainability.
> Also ensure new header is aligned to 100 columns.
>
> Signed-off-by: Stefan Binding <sbinding@xxxxxxxxxxxxxxxxxxxxx>
> ---
> include/sound/cs42l42.h | 810 ++++++++++++++++++++++++++++++++++++
> sound/soc/codecs/cs42l42.h | 826 +------------------------------------
> 2 files changed, 812 insertions(+), 824 deletions(-)
> create mode 100644 include/sound/cs42l42.h

You should use git format-patch -M for things like this, it makes the
diff more legible though in this case the fact that you've mixed content
changes in with the rename will not help - those are separate changes
and it's hard to verify things as they are. Still, seems to be OK

Acked-by: Mark Brown <broonie@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature