Re: Re: PING: [PATCH v4 0/5] virtio-crypto: Improve performance

From: zhenwei pi
Date: Thu May 05 2022 - 05:33:25 EST



On 5/5/22 12:57, Michael S. Tsirkin wrote:
On Thu, May 05, 2022 at 03:14:40AM +0000, Gonglei (Arei) wrote:


-----Original Message-----
From: zhenwei pi [mailto:pizhenwei@xxxxxxxxxxxxx]
Sent: Thursday, May 5, 2022 10:35 AM
To: Gonglei (Arei) <arei.gonglei@xxxxxxxxxx>; mst@xxxxxxxxxx;
jasowang@xxxxxxxxxx
Cc: herbert@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx; linux-crypto@xxxxxxxxxxxxxxx;
helei.sig11@xxxxxxxxxxxxx; davem@xxxxxxxxxxxxx
Subject: PING: [PATCH v4 0/5] virtio-crypto: Improve performance

Hi, Lei

Jason replied in another patch:
Still hundreds of lines of changes, I'd leave this change to other maintainers to
decide.

Quite frankly, the virtio crypto driver changed only a few in the past, and the
performance of control queue is not good enough. I am in doubt about that this
driver is not used widely. So I'd like to rework a lot, it would be best to complete
this work in 5.18 window.

This gets different point with Jason. I would appreciate it if you could give me
any hint.


This is already in my todo list.

Regards,
-Gonglei

It's been out a month though, not really acceptable latency for review.
So I would apply this for next, but you need to address Dan Captenter's
comment, and look for simular patterns elesewhere in your patch.


I fixed this in the v5 series. Thanks!

--
zhenwei pi