Re: [PATCH 0/3] fbdev: Fix use-after-free caused by wrong fb_info cleanup in drivers

From: Javier Martinez Canillas
Date: Thu May 05 2022 - 04:30:57 EST


Hello Thomas,

On 5/5/22 10:16, Thomas Zimmermann wrote:

[snip]

>> Patch #1 adds a WARN_ON() to framebuffer_release() to prevent the use-after-free
>> to happen.
>>
>> Patch #2 and patch #3 fixes the simplefb and efifb drivers respectively, to
>> free the resources at the correct place.
>
> From a quick look, vesafb seems to be affected as well.
>

Right, I wrongly assumed that we only cared about efifb and simplefb but forgot
that vesafb is used when setting a VESA mode with vga=foo. I'll add it in a v2.

> Best regards
> Thomas
>

--
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat