Re: [PATCH v2 01/13] arm64: stackleak: fix current_top_of_stack()

From: Will Deacon
Date: Thu May 05 2022 - 04:26:17 EST


On Wed, May 04, 2022 at 08:55:39PM +0100, Catalin Marinas wrote:
> On Wed, May 04, 2022 at 12:01:11PM -0700, Kees Cook wrote:
> > On Wed, May 04, 2022 at 05:41:32PM +0100, Catalin Marinas wrote:
> > > On Wed, Apr 27, 2022 at 06:31:16PM +0100, Mark Rutland wrote:
> > > > [...]
> > > > Fixes: 0b3e336601b82c6a ("arm64: Add support for STACKLEAK gcc plugin")
> > > > Signed-off-by: Mark Rutland <mark.rutland@xxxxxxx>
> > > > Cc: Alexander Popov <alex.popov@xxxxxxxxx>
> > > > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > > > Cc: Andy Lutomirski <luto@xxxxxxxxxx>
> > > > Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
> > > > Cc: Kees Cook <keescook@xxxxxxxxxxxx>
> > > > Cc: Will Deacon <will@xxxxxxxxxx>
> > >
> > > I thought this was queued already but I couldn't find it in -next. So:
> > >
> > > Acked-by: Catalin Marinas <catalin.marinas@xxxxxxx>
> >
> > Should this patch go via the arm64 tree for -rc6, or should I just carry
> > it as part of the overall stackleak series?
>
> I'll leave this up to Will (we take turns in managing the kernel
> releases) but it doesn't look urgent at all to me since it fixes a
> commit in 4.19.

Agreed, and nobody has actually experienced a problem with the current code
afaict, so I'd prefer to leave this with the rest of the series rather than
run the risk of a late regression.

Will