Re: [PATCH] drm: simplify the return expression of ast_drm_resume()

From: Thomas Zimmermann
Date: Thu May 05 2022 - 03:32:42 EST


Hi

Am 05.05.22 um 04:22 schrieb cgel.zte@xxxxxxxxx:
From: Minghao Chi <chi.minghao@xxxxxxxxxx>

Simplify the return expression.

Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
Signed-off-by: Minghao Chi <chi.minghao@xxxxxxxxxx>

Thanks a lot. I added your patch to drm-misc-next.

Best regards
Thomas

---
drivers/gpu/drm/ast/ast_drv.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/ast/ast_drv.c b/drivers/gpu/drm/ast/ast_drv.c
index 7465c4f0156a..760b27971557 100644
--- a/drivers/gpu/drm/ast/ast_drv.c
+++ b/drivers/gpu/drm/ast/ast_drv.c
@@ -159,15 +159,10 @@ static int ast_drm_thaw(struct drm_device *dev)
static int ast_drm_resume(struct drm_device *dev)
{
- int ret;
-
if (pci_enable_device(to_pci_dev(dev->dev)))
return -EIO;
- ret = ast_drm_thaw(dev);
- if (ret)
- return ret;
- return 0;
+ return ast_drm_thaw(dev);
}
static int ast_pm_suspend(struct device *dev)

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

Attachment: OpenPGP_signature
Description: OpenPGP digital signature