Re: [PATCH] scsi: sr: Fix some cdroms automatically ejected when booting into the system

From: job jin
Date: Wed May 04 2022 - 23:02:39 EST


Hi Martin K. Petersen!

As things stand, we cannot guarantee that all events will be propagated
to udev. So I think, we don't need to ensure that all events are received
by udev, we only need to ensure that events after sr probe can be received
by udev and actively discard events before sr probe.



>
>
> Hi jinxiaobo!
>
> > sr_get_events() has been called before udev starts when SCSI CDROM is
> > built-in and AHCI SATA is bulit-in,so sr events propagated to user
> > space are not handled. if both is loadable, udev will handle sr
> > events, some cdroms may eject. We need call sr_get_events() once
> > before device_add_disk() to keep the same result, whether both are
> > built-in or loadable.
>
> I am not sure how calling sr_get_events() and throwing away the result
> ensures that events get propagated to udev. Isn't this just changing
> timing slightly?
>
> --
> Martin K. Petersen Oracle Linux Engineering
>