Re: [RFC PATCH v6 07/11] leds: trigger: netdev: use mutex instead of spinlocks

From: Andrew Lunn
Date: Wed May 04 2022 - 21:10:57 EST


> @@ -400,7 +400,7 @@ static int netdev_trig_notify(struct notifier_block *nb,
>
> cancel_delayed_work_sync(&trigger_data->work);
>
> - spin_lock_bh(&trigger_data->lock);
> + mutex_lock(&trigger_data->lock);

I'm not sure you can convert a spin_lock_bh() in a mutex_lock().

Did you check this? What context is the notifier called in?

Andrew