Re: [PATCH v4] zram: remove double compression logic

[Minchan Kim]

On Wed, May 04, 2022 at 03:12:43PM +0300, Alexey Romanov wrote:
> The 2nd trial allocation under per-cpu presumption has been
> used to prevent regression of allocation failure. However, it
> makes trouble for maintenance without significant benefit.
> The slowpath branch is executed extremely rarely: getting
> there is problematic. Therefore, we delete this branch.

Let's add about the stable_write, too in the description.


"Since b09ab054b69b, zram has used QUEUE_FLAG_STABLE_WRITES to prevent
buffer change between 1st and 2nd memory allocations. Since we remove
second trial memory allocation logic, we could remove the STABLE_WRITES
flag because there is no change buffer to be modified under us"

> 
> Signed-off-by: Alexey Romanov <avromanov@xxxxxxxxxxxxxx>
> Signed-off-by: Dmitry Rokosov <ddrokosov@xxxxxxxxxxxxxx>

Other than that, looks good to me.

Acked-by: Minchan Kim <minchan@xxxxxxxxxx>

Please send the updated patch again with To: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
with keeping Ccing.