Re: [PATCH v2 3/3] arm64: dts: intel: add device tree for n6000

[matthew . gerlach]

On Wed, 4 May 2022, Krzysztof Kozlowski wrote:

> On 03/05/2022 21:45, matthew.gerlach@xxxxxxxxxxxxxxx wrote:
> > From: Matthew Gerlach <matthew.gerlach@xxxxxxxxxxxxxxx>
> >
> > Add a device tree for the n6000 instantiation of Agilex
> > Hard Processor System (HPS).
> >
> > Signed-off-by: Matthew Gerlach <matthew.gerlach@xxxxxxxxxxxxxxx>
> > +
> > +&spi0 {
> > +	status = "okay";
> > +
> > +	spidev: spidev@0 {
> > +		status = "okay";
> > +		compatible = "linux,spidev";
> > +		spi-max-frequency = <25000000>;
> > +		reg = <0>;
>
> You should see big fat warnings - from checkpatch and when you boot your
> device. This compatible is not accepted.

I must have missed the warning for the compatible string.  I see it now, 
and I remove the node in the v3 patch set.

Thanks for the feedback.
> Please be sure you run checkpatch on your patches. Using reviewers time
> instead of automated tool for the same job is discouraged...
>
>
> Best regards,
> Krzysztof