Re: [PATCH RESEND] arm64: dts: ti: k3-am642-sk: Add DT entry for onboard LEDs

From: Pavel Machek
Date: Wed May 04 2022 - 14:06:29 EST


Hi!

> > + led-7 {
> > + color = <LED_COLOR_ID_AMBER>;
> > + function = LED_FUNCTION_INDICATOR;
> > + function-enumerator = <8>;
> > + linux,default-trigger = "heartbeat";
> > + gpios = <&exp2 7 GPIO_ACTIVE_HIGH>;
> > + };
>
> This might also be LED_FUNCTION_HEARTBEAT, but it's probably up to
> author's personal preferences?

You are right that having 8 leds marked as indicator is not too useful.

> I added the linux-leds list to Cc.

Thank you!
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html