Re: [PATCH RESEND v6 (corrected v2) 2/2] leds: ktd2692: Make aux-gpios optional

[Andy Shevchenko]

On Wed, May 4, 2022 at 5:38 PM Markuss Broks <markuss.broks@xxxxxxxxx> wrote:
>
> Make the AUX pin optional, since it isn't a core part of functionality,
> and the device is designed to be operational with only one CTRL pin.
>
> Also pick up maintenance for the LED driver and the yaml bindings.


The MAINTAINERS update seems like it deserves a separate patch.
But most importantly, you need to add a patch that converts the error
reporting to use dev_err_probe(). Currently code has that issue, i.e.
it will print the error message as many times as probe was deferred
due to unreadiness of GPIO.

Something like this

>                 dev_err(dev, "cannot get aux-gpios %d\n", ret);
>                 return ret;

===>

  return dev_err_probe(dev, ret, "cannot get aux-gpios\n");

with a Fixes tag added.

-- 
With Best Regards,
Andy Shevchenko