Re: [PATCH] spi: dt-bindings: qcom,spi-geni-qcom: allow three interconnects

From: Rob Herring
Date: Wed May 04 2022 - 11:37:11 EST


On Wed, May 04, 2022 at 02:51:19PM +0200, Krzysztof Kozlowski wrote:
> Recent Qualcomm Geni SPI nodes, e.g. on SM8450, come with three
> interconnects. This fixes dtbs_check warnings like:
>
> sm8450-qrd.dtb: geniqup@8c0000: spi@880000:interconnect-names: ['qup-core', 'qup-config'] is too short

I'm confused. A length of 2 was already allowed before this change.

>
> Fixes: 5bdcae1fe1c5 ("spi: dt-bindings: qcom,spi-geni-qcom: convert to dtschema")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> ---
>
> Fix for a commit in MSM/Bjorn's tree.
> ---
> .../devicetree/bindings/spi/qcom,spi-geni-qcom.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
> index e2c7b934c50d..47e1b3ee8b1b 100644
> --- a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
> +++ b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
> @@ -45,12 +45,15 @@ properties:
> - const: rx
>
> interconnects:
> - maxItems: 2
> + minItems: 2
> + maxItems: 3
>
> interconnect-names:
> + minItems: 2
> items:
> - const: qup-core
> - const: qup-config
> + - const: qup-memory
>
> interrupts:
> maxItems: 1
> --
> 2.32.0
>
>