Re: [RFC v2 1/4] net: dsa: mt7530: rework mt7530_hw_vlan_{add,del}

From: Vladimir Oltean
Date: Wed May 04 2022 - 11:21:49 EST


On Sat, Apr 30, 2022 at 03:03:44PM +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
>
> Rework vlan_add/vlan_del functions in preparation for dynamic cpu port.
>
> Currently BIT(MT7530_CPU_PORT) is added to new_members, even though
> mt7530_port_vlan_add() will be called on the CPU port too.
>
> Let DSA core decide when to call port_vlan_add for the CPU port, rather
> than doing it implicitly.
>
> We can do autonomous forwarding in a certain VLAN, but not add br0 to that
> VLAN and avoid flooding the CPU with those packets, if software knows it
> doesn't need to process them.
>
> Suggested-by: Vladimir Oltean <olteanv@xxxxxxxxx>
> Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
> ---

Reviewed-by: Vladimir Oltean <olteanv@xxxxxxxxx>