Re: [PATCH bpf-next] bpf/xdp: Can't detach BPF XDP prog if not exist

From: Toke Høiland-Jørgensen
Date: Wed May 04 2022 - 07:19:59 EST


Zhengchao Shao <shaozhengchao@xxxxxxxxxx> writes:

> if user sets nonexistent xdp_flags to detach xdp prog, kernel should
> return err and tell user that detach failed with detail info.
>
> Signed-off-by: Zhengchao Shao <shaozhengchao@xxxxxxxxxx>

I kinda see your point, but this will change user-visible behaviour that
applications might be relying on, so I don't think we can make this
change at this stage. Why can't your application just query the link for
whether a program is attached?

-Toke