Re: [PATCH v2] net: sfp: Add tx-fault workaround for Huawei MA5671A SFP ONT

From: Andrew Lunn
Date: Tue May 03 2022 - 18:19:06 EST


On Mon, May 02, 2022 at 11:33:15PM +0100, Matthew Hagan wrote:
> As noted elsewhere, various GPON SFP modules exhibit non-standard
> TX-fault behaviour. In the tested case, the Huawei MA5671A, when used
> in combination with a Marvell mv88e6085 switch, was found to
> persistently assert TX-fault, resulting in the module being disabled.
>
> This patch adds a quirk to ignore the SFP_F_TX_FAULT state, allowing the
> module to function.
>
> Change from v1: removal of erroneous return statment (Andrew Lunn)
>
> Signed-off-by: Matthew Hagan <mnhagan88@xxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew