Re: [PATCH v3 1/2] dt-bindings: google,cros-ec-keyb: Introduce switches only compatible

From: Stephen Boyd
Date: Tue May 03 2022 - 15:40:37 EST


Quoting Doug Anderson (2022-05-03 08:09:04)
> Hi,
>
> On Mon, May 2, 2022 at 9:22 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote:
> >
> > @@ -113,3 +135,56 @@ examples:
> > /* UP LEFT */
> > 0x070b0067 0x070c0069>;
> > };
> > +
> > + - |
> > + keyboard-controller {
> > + compatible = "google,cros-ec-keyb-switches", "google,cros-ec-keyb";
> > + /* Matrix keymap properties are allowed but ignored */
>
> nit: s/allowed/required/

Ok. I will roll it in and resend.

>
> This now looks reasonable and well explained to me.
>
> Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

Thanks.