Re: [PATCH v3 00/12] KVM: SVM: Fix soft int/ex re-injection

From: Sean Christopherson
Date: Tue May 03 2022 - 14:48:21 EST


On Mon, May 02, 2022, Maciej S. Szmigiero wrote:
> From: "Maciej S. Szmigiero" <maciej.szmigiero@xxxxxxxxxx>
>
> This series is an updated version of Sean's SVM soft interrupt/exception
> re-injection fixes patch set, which in turn extended and generalized my
> nSVM L1 -> L2 event injection fixes series.
>
> Detailed list of changes in this version:
> * "Downgraded" the commit affecting !nrips CPUs to just drop nested SVM
> support for such parts instead of SVM support in general,
>
> * Removed the BUG_ON() from svm_inject_irq() completely, instead of
> replacing it with WARN() - Maxim has pointed out it can still be triggered
> by userspace via KVM_SET_VCPU_EVENTS,
>
> * Updated the new KVM self-test to switch to an alternate IDT before attempting
> a second L1 -> L2 injection to cause intervening NPF again,
>
> * Added a fix for L1/L2 NMI state confusion during L1 -> L2 NMI re-injection,
>
> * Updated the new KVM self-test to also check for the NMI injection
> scenario being fixed (that was found causing issues with a real guest),
>
> * Changed "kvm_inj_virq" trace event "reinjected" field type to bool,
>
> * Integrated the fix from patch 5 for nested_vmcb02_prepare_control() call
> argument in svm_set_nested_state() to patch 1,
>
> * Collected Maxim's "Reviewed-by:" for tracepoint patches.
>
> Previous versions:
> Sean's v2:
> https://lore.kernel.org/kvm/20220423021411.784383-1-seanjc@xxxxxxxxxx
>
> Sean's v1:
> https://lore.kernel.org/kvm/20220402010903.727604-1-seanjc@xxxxxxxxxx
>
> My original series:
> https://lore.kernel.org/kvm/cover.1646944472.git.maciej.szmigiero@xxxxxxxxxx
>
> Maciej S. Szmigiero (4):
> KVM: nSVM: Sync next_rip field from vmcb12 to vmcb02
> KVM: SVM: Don't BUG if userspace injects an interrupt with GIF=0

LOL, this should win some kind of award for most ridiculous multi-author patch :-)

Series looks good, thanks!