Re: [PATCH] selinux: resolve checkpatch errors

[Paul Moore]

On Mon, May 2, 2022 at 9:49 AM Christian Göttsche
<cgzones@xxxxxxxxxxxxxx> wrote:
>
> Reported by checkpatch:
>
>     security/selinux/nlmsgtab.c
>     ---------------------------
>     ERROR: that open brace { should be on the previous line
>     #29: FILE: security/selinux/nlmsgtab.c:29:
>     +static const struct nlmsg_perm nlmsg_route_perms[] =
>     +{
>
>     ERROR: that open brace { should be on the previous line
>     #97: FILE: security/selinux/nlmsgtab.c:97:
>     +static const struct nlmsg_perm nlmsg_tcpdiag_perms[] =
>     +{
>
>     ERROR: that open brace { should be on the previous line
>     #105: FILE: security/selinux/nlmsgtab.c:105:
>     +static const struct nlmsg_perm nlmsg_xfrm_perms[] =
>     +{
>
>     ERROR: that open brace { should be on the previous line
>     #134: FILE: security/selinux/nlmsgtab.c:134:
>     +static const struct nlmsg_perm nlmsg_audit_perms[] =
>     +{
>
>     security/selinux/ss/policydb.c
>     ------------------------------
>     ERROR: that open brace { should be on the previous line
>     #318: FILE: security/selinux/ss/policydb.c:318:
>     +static int (*destroy_f[SYM_NUM]) (void *key, void *datum, void *datap) =
>     +{
>
>     ERROR: that open brace { should be on the previous line
>     #674: FILE: security/selinux/ss/policydb.c:674:
>     +static int (*index_f[SYM_NUM]) (void *key, void *datum, void *datap) =
>     +{
>
>     ERROR: that open brace { should be on the previous line
>     #1643: FILE: security/selinux/ss/policydb.c:1643:
>     +static int (*read_f[SYM_NUM]) (struct policydb *p, struct symtab *s, void *fp) =
>     +{
>
>     ERROR: that open brace { should be on the previous line
>     #3246: FILE: security/selinux/ss/policydb.c:3246:
>     +                               void *datap) =
>     +{
>
> Signed-off-by: Christian Göttsche <cgzones@xxxxxxxxxxxxxx>
> ---
>  security/selinux/include/initial_sid_to_string.h |  3 +--
>  security/selinux/nlmsgtab.c                      | 12 ++++--------
>  security/selinux/ss/policydb.c                   | 12 ++++--------
>  3 files changed, 9 insertions(+), 18 deletions(-)

I generally dislike checkpatch-only patches, but you've been fixing a
lot of other things so I'll go ahead and merge this into selinux/next.

-- 
paul-moore.com